Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced webpa-common/logging with zap logger #141

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino added enhancement webpa-common archival/deprecation work related to the archival & deprecation of webpa-common labels Jun 23, 2023
@maurafortino maurafortino added this to In progress in XMiDT via automation Jun 23, 2023
@maurafortino maurafortino self-assigned this Jun 23, 2023
@guardrails
Copy link

guardrails bot commented Jun 23, 2023

⚠️ We detected 4 security issues in this pull request:

Vulnerable Libraries (4)
Severity Details
N/A pkg:golang/github.com/xmidt-org/sallust@v0.2.2 - no patch available
N/A pkg:golang/go.uber.org/zap@v1.24.0 - no patch available
N/A pkg:golang/github.com/stretchr/testify@v1.8.3 - no patch available
N/A pkg:golang/github.com/xmidt-org/webpa-common/v2@v2.2.0 - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #141 (fcdfb99) into main (f524c05) will increase coverage by 8.92%.
Report is 4 commits behind head on main.
The diff coverage is 25.86%.

@@           Coverage Diff            @@
##            main    #141      +/-   ##
========================================
+ Coverage   0.00%   8.92%   +8.92%     
========================================
  Files          1       2       +1     
  Lines        129     168      +39     
========================================
+ Hits           0      15      +15     
- Misses       129     153      +24     
Flag Coverage Δ
unittests 8.92% <25.86%> (+8.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
main.go 0.00% <0.00%> (ø)
basculeLogging.go 34.88% <34.88%> (ø)

XMiDT automation moved this from In progress to PRs: Approved Jul 18, 2023
@maurafortino maurafortino merged commit c4e3d41 into main Sep 22, 2023
16 of 17 checks passed
XMiDT automation moved this from PRs: Approved to Done Sep 22, 2023
@maurafortino maurafortino deleted the zap-logger branch September 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
XMiDT
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants