Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Add support for additional key/value pairs in X-MoneyTrace header #44

Merged
merged 1 commit into from Jan 12, 2024

Conversation

HaloFour
Copy link

@HaloFour HaloFour commented Oct 26, 2020

Adds support for additional unrecognized key/value pairs in the X-MoneyTrace header. The header will be considered value as long as it has at least 3 key/value pairs and that each of the trace-id,parent-id and span-id keys have been seen. Any other key/value pairs will be ignored.

See: #43
Comcast/money#158

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2020

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #44 into master will increase coverage by 1.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   67.95%   69.48%   +1.52%     
==========================================
  Files           4        4              
  Lines         181      154      -27     
==========================================
- Hits          123      107      -16     
+ Misses         55       45      -10     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
trace.go 100.00% <100.00%> (ø)
span.go 90.47% <0.00%> (-1.02%) ⬇️
tracker.go 4.76% <0.00%> (-1.01%) ⬇️
spanner.go 89.28% <0.00%> (+4.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02874fc...c28ef32. Read the comment docs.

@schmidtw schmidtw merged commit 31eb2e9 into xmidt-org:master Jan 12, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants