Skip to content

Commit

Permalink
updated changelog and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kristinapathak committed Nov 21, 2019
1 parent 4d2c47a commit 5034e5d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [v0.3.2]
- Updated batchInserter to have a configurable amount of batchers [#18](https://github.com/xmidt-org/codex-db/pull/18)

## [v0.3.1]
- Fixed typo in variable name [[#15](https://github.com/xmidt-org/codex-db/pull/15)]
- Fix metric cardinality [[#17](https://github.com/xmidt-org/codex-db/pull/17)]
Expand All @@ -30,7 +33,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [v0.1.0]
- Initial creation, moved from: https://github.com/xmidt-org/codex-deploy

[Unreleased]: https://github.com/xmidt-org/codex-db/compare/v0.3.1..HEAD
[Unreleased]: https://github.com/xmidt-org/codex-db/compare/v0.3.2..HEAD
[v0.3.2]: https://github.com/xmidt-org/codex-db/compare/v0.3.1..v0.3.2
[v0.3.1]: https://github.com/xmidt-org/codex-db/compare/v0.3.0..v0.3.1
[v0.3.0]: https://github.com/xmidt-org/codex-db/compare/v0.2.0..v0.3.0
[v0.2.0]: https://github.com/xmidt-org/codex-db/compare/0.1.2...v0.2.0
Expand Down
11 changes: 7 additions & 4 deletions batchInserter/batchInserter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
"github.com/go-kit/kit/metrics/provider"
"github.com/stretchr/testify/assert"

"github.com/xmidt-org/codex-db"
db "github.com/xmidt-org/codex-db"
"github.com/xmidt-org/webpa-common/xmetrics/xmetricstest"
)

Expand All @@ -40,7 +40,8 @@ func TestNewBatchInserter(t *testing.T) {
goodMeasures := NewMeasures(goodRegistry)
goodConfig := Config{
QueueSize: 1000,
MaxWorkers: 5000,
ParseWorkers: 50,
MaxInsertWorkers: 5000,
MaxBatchSize: 100,
MaxBatchWaitTime: 5 * time.Hour,
}
Expand Down Expand Up @@ -81,7 +82,8 @@ func TestNewBatchInserter(t *testing.T) {
MaxBatchSize: defaultMaxBatchSize,
MaxBatchWaitTime: minMaxBatchWaitTime,
QueueSize: defaultMinQueueSize,
MaxWorkers: defaultMaxWorkers,
ParseWorkers: minParseWorkers,
MaxInsertWorkers: defaultInsertWorkers,
},
logger: defaultLogger,
},
Expand Down Expand Up @@ -191,7 +193,8 @@ func TestBatchInserter(t *testing.T) {
config: Config{
MaxBatchWaitTime: 10 * time.Millisecond,
MaxBatchSize: 3,
MaxWorkers: 5,
ParseWorkers: 1,
MaxInsertWorkers: 5,
},
inserter: inserter,
insertQueue: queue,
Expand Down

0 comments on commit 5034e5d

Please sign in to comment.