Add displayValueForFirstRow and displayValueForSecondRow closure in DoublePickerInlineRow #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilidotshi
changed the title
lilidotshi
changed the title
|
@mats-claassen any thoughts on this PR? Should be pretty simple, just bringing the inline picker up to parity with the others. Our project is blocked by this otherwise, unless we write our own cell. |
mats-claassen
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way to configure the way that an DoublePickerInlineRow displays its values in the picker, which is avaliable in DoublePickerRow and DoublePickerInputRow. This pull request addresses that missing feature.
After:
