Skip to content

Commit

Permalink
Remove unused variables
Browse files Browse the repository at this point in the history
Remove unused variables and attributes from BaseViewConversionHelper
on mlir/lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp

Closes tensorflow#116

COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#116 from alexst07:fix-warnings 5f638e4677492cf71a9cc040eeb6b57427d32e06
PiperOrigin-RevId: 266972082
  • Loading branch information
alexst07 authored and tensorflower-gardener committed Sep 3, 2019
1 parent e6d77ed commit b09e5b9
Showing 1 changed file with 7 additions and 13 deletions.
20 changes: 7 additions & 13 deletions lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -185,20 +185,19 @@ class BaseViewConversionHelper {
BaseViewConversionHelper(Operation *op, ViewType viewType,
ConversionPatternRewriter &rewriter,
LLVMTypeConverter &lowering)
: indexType(rewriter.getIndexType()), viewType(viewType),
elementTy(getPtrToElementType(viewType, lowering)),
: elementTy(getPtrToElementType(viewType, lowering)),
int64Ty(
lowering.convertType(rewriter.getIntegerType(64)).cast<LLVMType>()),
viewDescriptorPtrTy(
convertLinalgType(viewType, lowering).cast<LLVMType>()),
rewriter(rewriter) {

IndexType indexType = rewriter.getIndexType();
viewDescriptorPtrTy =
convertLinalgType(viewType, lowering).cast<LLVMType>();
OpBuilder::InsertionGuard insertGuard(rewriter);
rewriter.setInsertionPointToStart(
&op->getParentOfType<FuncOp>().getBlocks().front());

edsc::ScopedContext context(rewriter, op->getLoc());
one = constant(int64Ty, IntegerAttr::get(indexType, 1));
Value *one = constant(int64Ty, IntegerAttr::get(indexType, 1));
// Alloca with proper alignment.
allocatedDesc = llvm_alloca(viewDescriptorPtrTy, one, /*alignment=*/8);
// Load the alloca'ed descriptor.
Expand All @@ -209,11 +208,9 @@ class BaseViewConversionHelper {
return positionAttr(rewriter, values);
};

IndexType indexType;
ViewType viewType;
LLVMType elementTy, int64Ty, viewDescriptorPtrTy;
ConversionPatternRewriter &rewriter;
Value *one, *allocatedDesc, *desc;
Value *allocatedDesc, *desc;
};
} // namespace

Expand Down Expand Up @@ -594,10 +591,7 @@ class TransposeOpConversion : public LLVMOpLowering {
auto tranposeOp = cast<TransposeOp>(op);
BaseViewConversionHelper helper(op, tranposeOp.getViewType(), rewriter,
lowering);
IndexType indexType = helper.indexType;
ViewType viewType = helper.viewType;
LLVMType elementTy = helper.elementTy, int64Ty = helper.int64Ty,
viewDescriptorPtrTy = helper.viewDescriptorPtrTy;
LLVMType elementTy = helper.elementTy, int64Ty = helper.int64Ty;
Value *allocatedDesc = helper.allocatedDesc, *desc = helper.desc;

edsc::ScopedContext context(rewriter, op->getLoc());
Expand Down

0 comments on commit b09e5b9

Please sign in to comment.