Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #351 on 10.14+ #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dustinknopoff
Copy link

Summary

It looks like the main issue in #351 was the use of NSAppearance.vibrantDark instead of .darkAqua. This is due to vibrantDark using color blending instead of the system colors. Source This was probably done because .darkAqua only appears in 10.14+. I guess the option here is keep having too dark buttons prior to 10.14 or just always use the unified_titlebar colors.

Related Issues

Related to #351

Checklist

Example:

  • Example check-list item
  • Create a pull request template
  • make xi perfect

Review Checklist

  • I have responded to reviews and made changes where appropriate.
  • I have tested the code
  • I have updated comments / documentation related to the changes I made.
  • I have rebased my PR branch onto xi-mac/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant