Add a LineOffset trait
#1259
Merged
Add a LineOffset trait
#1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cogitri
approved these changes
Mar 28, 2020
rust/core-lib/src/movement.rs
Outdated
| @@ -12,12 +12,12 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| //! Representation and calculation of movement within a view. | |||
| //! Representation and calculation of movement within a lo. | |||
There was a problem hiding this comment.
Nitty, but IMHO it'd make sense to just say lineoffset here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
LineOffsettrait, allowing the use ofoffset_of_line,line_of_offset,offset_to_line_colandline_col_to_offsetwithout needing aView.In addition, the functions in
movement.rsnow use this trait instead.Related Issues
Related to #1198
Review Checklist
cargo test --all/./rust/run_all_checks.