Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mouse scrolling for single and double page style navigation #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syang44
Copy link

@syang44 syang44 commented Dec 4, 2023

Implemented mouse scrolling for single and double page style navigation. Scroll down navigates to the next pages and vice versa.

Fixes #237

@xgi
Copy link
Owner

xgi commented Dec 19, 2023

This has an issue where if the page is long / not constrained by window height (i.e. you only see one page but there's still a scrollbar), scrolling will cause it to go to the next page even if you just want to get to the bottom of the image.

Think there'd need to be logic to check if the user is scrolling down while at the bottom (or vice versa). I'm not sure if that's easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse scrolling for single and double page style navigation
2 participants