Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to resolve a bunch of issues that stem from the fact that we still support
periodic
as input. This should stop right here.This is a reimplementation of #534 which is quite far behind at this point (my apologies to the original author for falling behind on the maintainer duties here).
Totally just taking a first stab here to give people a point of reference. This needs some careful (not past 9pm) consideration of how to change the tests. The fact that periodic is so deeply embedded into the test suite is really the reason that it was not removed earlier.
pre-commit run --all-files
whats-new.rst
api.rst