New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter input checks #569

Open

TomNicholas wants to merge 27 commits into xgcm:master from TomNicholas:stricter_input_checks

Contributor

TomNicholas commented Dec 16, 2022

WIP to make the checks on user input to the Grid constructor stricter. Factored out of #557 because lots of the test fixtures don't actually conform to these stricter checks, causing lots of new failures.

Closes #xxxx
Tests added
Passes pre-commit run --all-files
User visible changes (including notable bug fixes) are documented in whats-new.rst
New functions/methods are listed in api.rst

TomNicholas and others added 27 commits

November 15, 2022 15:52


          moved Axis to its own file

708e71e


          [pre-commit.ci] auto fixes from pre-commit.com hooks

f6a157e

for more information, see https://pre-commit.ci


          migrate transform logic from axis to grid

f7a5567


          improve error messages

a056030


          Merge branch 'remove_Axis2' of https://github.com/TomNicholas/xgcm in…

c9a3e17

…to remove_Axis2


          Merge pull request #1 from jbusecke/remove_axis_transform_fix

c2788c6

migrate transform logic from axis to grid


          Merge branch 'master' into remove_Axis2

d5185df


          [pre-commit.ci] auto fixes from pre-commit.com hooks

809baa1

for more information, see https://pre-commit.ci


          fixed merge conflicts with transform PR by adding in missing imports

9e98eeb


          test initialisation of Axis class

3c69dfb


          move all tests concerning Axis class out of grid.py

fa5d12e


          put comodo parsing in its place

adab3f5


          moved default setting to only occur in Axis init

026d2a8


          [pre-commit.ci] auto fixes from pre-commit.com hooks

c3c0ea1

for more information, see https://pre-commit.ci


          fixed some bugs with repr

6bebe74


          re-established assert_axis_equals function in tests

685d448


          test to ensure bug with same position is raised

971f337


          Merge branch 'remove_Axis2' of https://github.com/TomNicholas/xgcm in…

7ad4135

…to remove_Axis2


          [pre-commit.ci] auto fixes from pre-commit.com hooks

1381af6

for more information, see https://pre-commit.ci


          fixed bug with padding defaults

6ea6a5e


          fixed regex error

eced7fc


          refactored consulting of axis defaults

e54a7cc


          Merge branch 'remove_Axis2' of https://github.com/TomNicholas/xgcm in…

29ccc0a

…to remove_Axis2


          fixed bug with repr and with periodic=False

ead933b


          fix problem with test supplying inconsistent input

f151ae4


          checks for extraneous axes provided

51e60f9


          [pre-commit.ci] auto fixes from pre-commit.com hooks

8f0ebeb

for more information, see https://pre-commit.ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment