Test suite without dask #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
changed the base branch from
master
to
grid_ufunc_refactor_project
|
Wait why didn't the CI run the code tests?? |
|
Umm that is weird...no idea why this wouldnt work... |
|
Do you envision this being part of 0.7.0? I would say this is probably more suited for the next round where we modify tests substantially? |
|
I think this is low-priority, and can wait until we have finalised the internals based on other criteria. |
|
Not sure this should be closed. Could be part of #466 |
|
The only reason this was closed is because when I tried deleting the |
|
Ok then ill reopen so we can keep track of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dask from the "core dependencies" CI environment file, so that no we have a CI run that tests everything without dask installed.
I altered an existing run rather than added a new run because this seemed to better fit the intention of "just core dependencies".
I don't expect this to pass - but we can push to this branch to start fixing any bugs that this reveals.