WIP: Implement reverse for cumsum method
#256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the pull request will be closed in another 30 days. Thank you for your contribution! |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request. |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request. |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cumintdirection #184black .whats-new.rstapi.rstI have attempted to implement a reversed cumulative sum. The method flips the
.dataalong the relevant axis, then applies the cumulative sum, and flips the data back.As a test case I expect the result to be equivalent to
da.sum(axis_dim) - grid.cumsum(axis).Some cases pass (outer/inner coords; except with
extentboundary), but others do not. Still working on understanding where this goes wrong.