Add url as identifier for spans coming from share #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vierbergenlars
requested changes
Dec 8, 2021
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## Release 0.1.0 (2021-11-29) | |||
There was a problem hiding this comment.
This release date is in the past?
And you add a change in this PR for something that would be in the release.
I don't understand how this is possible?
There was a problem hiding this comment.
The release never went trough since the Integration test is blocking it
There was a problem hiding this comment.
Oh well, turns out I read this diff in the opposite way.
I thought you added a release date, but in fact you removed it.
My bad.
vierbergenlars
approved these changes
Dec 8, 2021
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## Release 0.1.0 (2021-11-29) | |||
There was a problem hiding this comment.
Oh well, turns out I read this diff in the opposite way.
I thought you added a release date, but in fact you removed it.
My bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.