Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nv2a: Fix vertex Z calculation using clip range #1620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

camden-smallwood
Copy link
Contributor

As mentioned in this comment, this fix restores a number of missing UI elements in Halo 2 on Mac.

System Information

2020 M1 Mac mini
macOS 14.1.1

Fixed Behavior

Restored blue background on mainmenu:
image

Restored profile icons:
image

Restored UI elements:
image

@Spidy123222
Copy link

Spidy123222 commented Mar 26, 2024

This Pr fixes other games also it seems like burnout 3's menus (pitch black for most part in xemu before). I will have to test this on my steam deck as it also has these issues as from what others saw that it mostly was on integrated graphics devices or certain AMD gpu's #1223.
image
image

@Spidy123222
Copy link

so I tested the pull request on steam deck. doesn't fix it there unfortunately.

@HadetTheUndying
Copy link

so I tested the pull request on steam deck. doesn't fix it there unfortunately.

Does the SteamDeck issue persist if you switch to zink as your GL driver? I have a feeling this is still that same mesa issue that we've been dealing with for over a year now.

@Spidy123222
Copy link

Spidy123222 commented May 1, 2024

so I tested the pull request on steam deck. doesn't fix it there unfortunately.

Does the SteamDeck issue persist if you switch to zink as your GL driver? I have a feeling this is still that same mesa issue that we've been dealing with for over a year now.

Zink just breaks the graphics nowadays. Not sure why and this doesn't change that either. Both macOS and steam deck can be fixed and broken at same time with an environment variable that's not correct solution. As Matt said above the pr change could be wrong.

@ws141
Copy link

ws141 commented May 7, 2024

so I tested the pull request on steam deck. doesn't fix it there unfortunately.

Thanks for reporting I'm trying to get Burnout 3 going on my Steam Deck as well. ☹️

@Fabxx
Copy link
Contributor

Fabxx commented May 10, 2024

i've tested the first splinter cell with this PR, unfortunately you can still see through walls and objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants