Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: Add support for write command #1589

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jamesbrq
Copy link

Adds a new command to monitor named write|w. The syntax is write addr size data. This adds the capability to write up to 4 bytes of data at a time to the xbox.ram memory region.

@mborgerson
Copy link
Member

mborgerson commented Feb 20, 2024

Thank you for the PR

I was certain this must exist in QEMU monitor already, and was totally surprised not to find it! I usually just use GDB to do this, but I think it would be nice for users to be able to easily poke memory in the monitor too, for playing with games and whatnot, and the feature is not too complex. In the future maybe we should just bake in a GDB client for people to use.

In the mean time, can you please expand the PR to support writing to both physical and virtual arbitrary addresses, regardless of any particular internal region. You can model this after the other related monitor / GDB stub commands.

This feature might also be good for upstream QEMU, if you're interested in submitting to qemu-devel.

@jamesbrq
Copy link
Author

jamesbrq commented Feb 20, 2024

I added an extra command, so there is one for virtual and one for physical now.

I'm assuming the syntax and everything is okay but if you think anything else needs to be changed let me know.
I'll also have to look into upstream qemu as well, but I'll see if I can get around to it. At the very least having it on xemu will be a nice addition. I can finally write to ram without having to pause the whole emulator lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants