Update/testsuite #696
Merged
Update/testsuite #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Montagon
commented
Mar 21, 2024
•
Montagon
commented
# Conflicts: # evaluator/build.gradle.kts
raulraja
previously approved these changes
Mar 22, 2024
raulraja
previously approved these changes
Mar 22, 2024
javipacheco
previously approved these changes
Mar 22, 2024
There was a problem hiding this comment.
The proposal of the tests should be if the response is successful or not. In this case, we should be able to say what results of the metrics are the positives in order to say if the test failed.
We can address this in another separate PR. Anyway, I think that we should change the unaryPlus in the DSL
Good job!
evaluator/src/main/kotlin/com/xebia/functional/xef/evaluator/TestItemBuilder.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.