Minor fixes to areas/latency/cgroup_rstat_tracepoint.bt #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
…omic Fix comment about increment operator being atomic. It is both slow and contains data races as described here: - bpftrace/bpftrace#3175 Maybe this will soon get fixed via: - bpftrace/bpftrace#3179 - bpftrace#3179 Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
|
Sorry for the delay. We're still discussing atomic map updates and the tradeoffs. |
jordalgo
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bpftrace increment operator is both slow and contain data races.
Fix comment, where I thought slowness was due to it being an atomic operation.
Upstream bpftrace issues are in progress for improving performance and reduce data races: