[Video] Fix Episode NFO parsing error (introduced in #24565)

[78andyp]

Description

As reported in the forum https://forum.kodi.tv/showthread.php?tid=377480.

Error introduced in #24565 (I cannot reproduce the problem I was attempting to fix).

Also removed unneeded #include.

Motivation and context

Fix episode NFO parsing

How has this been tested?

Locally

What is the effect on users?

As above.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• Student submission (PR was done for educational purposes and will be treated as such)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[KarellenX]

Thank you @78andyp

@fuzzard do you mind kicking off a test build?

[fuzzard]

Win64 test build - https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240511-e04b6b7e-PR25198-merge-x64.exe

[KarellenX]

Thanks @fuzzard

[KarellenX]

Tested this fix and multi-episodes are now scanned into the library correctly. Performed a few other scans as well with and without nfo files, using local and tmdb scraper, and I could find no further problems.

Thanks for the quick fix @78andyp
Maybe a backport as well when you have time?

[CrystalP]

Reverting the previous change is good.
However did you check that each episode of a multi-episode received the correct details? I'm not familiar with that code and it looks a little weird to me. Maybe all episodes receive the same details instead of details of episode 1, 2, etc. respectively. Haven't had the chance to runtime test yet.

[KarellenX]

However did you check that each episode of a multi-episode received the correct details?

Yes, I checked. Title, Plot, Writers, Directors are correct for each episode.
Let me know if there is something else that needs checking.

[CrystalP]

Reverting the code fixes the incorrect m_headPos for the later GetDetails calls.

[CrystalP]

Let me know if there is something else that needs checking.

No that's OK, thanks. I stepped through the code to understand what's happening.