Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify network FileItem classifiers #25185

Merged
merged 2 commits into from May 12, 2024

Conversation

notspiff
Copy link
Contributor

Description

Drop unused parameter and use the fact that DynPath() returns Path() if no dynpath is available.

Motivation and context

Simpler code is better code

How has this been tested?

It builds and (modified) tests pass

What is the effect on users?

None

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff notspiff added Type: Improvement non-breaking change which improves existing functionality v22 "P" labels May 10, 2024
@notspiff notspiff added this to the "P" 22.0 Alpha 1 milestone May 10, 2024
@notspiff notspiff requested a review from CrystalP May 10, 2024 17:55
@notspiff notspiff changed the title Simplify network FileiIem classifiers Simplify network FileItem classifiers May 11, 2024
@notspiff notspiff merged commit a43c9b9 into xbmc:master May 12, 2024
2 checks passed
@notspiff notspiff deleted the simplify_network_fileitem_classifiers branch May 12, 2024 06:13
Copy link
Contributor

@CrystalP CrystalP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants