[video] Preserve special characters in default names of extras

[CrystalP]

Description

Use filenames as is as default name of extras added to movies.

Removed the StringUtils::ReplaceSpecialCharactersWithSpace() call.

The database storage/retrieval has proper escaping of the characters and works fine without.

Maybe worth a backport as this is very self-contained change, though technically it's not a bug fix.

Motivation and context

Noticed by forum user https://forum.kodi.tv/showthread.php?tid=337992&pid=3195791#pid3195791

The default name generated when adding an extra to a movie (through library scan or manual addition) has the special characters replaced with spaces;

special characters: .-_+,!'"/*?#$%&@()[]{} and tab

That's not intuitive and I didn't find a good reason for that filter.

How has this been tested?

sqlite and mariadb.

Since some of those characters cannot be naturally found in filenames (ex /), I changed the CGUIDialogVideoManagerExtras::GenerateVideoExtra() function to set a filename containing some normal text + all the special characters.

What is the effect on users?

Screenshots (if appropriate):

with filename "test .- _ +, !'"\t/\*?#$%&@()[]{} test" injected directly in GenerateVideoExtra

Before PR:

After PR:

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• Student submission (PR was done for educational purposes and will be treated as such)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed