Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compiler configs and docs #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Mar 3, 2022

It seems using different compiler settings for MobX 4 and 5/6 isn't necessary. Do you think this is generally valid? At least the test suite passes.

@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ Deploy Preview for mobx-keystone ready!

🔨 Explore the source changes: d5faaba

🔍 Inspect the deploy log: https://app.netlify.com/sites/mobx-keystone/deploys/6220da16abd31100077013b7

😎 Browse the preview: https://deploy-preview-421--mobx-keystone.netlify.app

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #421 (d5faaba) into master (17ffa8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         179      179           
  Lines        6388     6388           
  Branches     1168     1157   -11     
=======================================
  Hits         5809     5809           
  Misses        542      542           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ffa8e...d5faaba. Read the comment docs.

@xaviergonz
Copy link
Owner

I don't know, I think those config were taken directly from mobx docs, so while they might work with keystone they might not work if you use decorators for mobx itself

@sisp
Copy link
Contributor Author

sisp commented Mar 6, 2022

Okay, I'll investigate a bit further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants