Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partial batches #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arbennett
Copy link

Description of proposed changes

This is a simple additional flag that allows for "partial" batches to be returned.

Fixes #123

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #177 (42de55a) into main (1b58f96) will decrease coverage by 0.57%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   96.04%   95.48%   -0.57%     
==========================================
  Files           6        6              
  Lines         329      332       +3     
  Branches       70       71       +1     
==========================================
+ Hits          316      317       +1     
- Misses          8        9       +1     
- Partials        5        6       +1     
Impacted Files Coverage Δ
xbatcher/generators.py 93.60% <50.00%> (-1.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@maxrjones
Copy link
Member

@arbennett sorry for the very slow response! This is great!

It would be good to include add a test for this functionality before merging. Please let me know if you'd want to add a test or I can push one if you don't have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide the option to return partial batches
2 participants