Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the option to return partial batches #123

Open
maxrjones opened this issue Nov 4, 2022 · 0 comments · May be fixed by #177
Open

Provide the option to return partial batches #123

maxrjones opened this issue Nov 4, 2022 · 0 comments · May be fixed by #177
Labels
feature

Comments

@maxrjones
Copy link
Member

maxrjones commented Nov 4, 2022 •
edited

Is your feature request related to a problem?

As explained in #82, xbatcher throws away partial batches if the input_dims dimension is not evenly divisible by the value provided.

Describe the solution you'd like

As noted in

xbatcher/xbatcher/tests/test_generators.py

Lines 66 to 67 in f04ad18

# TODO: decide how to handle bsizes like 15 that don't evenly divide the dimension
# Should we enforce that each batch size always has to be the same
we could consider adding a parameter that specifies that the batch generator should also return partial batches.

Describe alternatives you've considered

If there is no strong need for this feature, we could keep the status-quo of only returning equal-sized batches.

Additional context

No response
@arbennett arbennett linked a pull request Mar 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow partial batches arbennett/xbatcher
1 participant
@maxrjones