Implement coords validation #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @garciampred - thanks for opening this PR! This project has been indeed been quite lately but its not dead. Toward this PR, it would be great to see a test added as well. |
from_json method has been fixed too.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this package. First of all, I am not sure if anyone is looking at this. Let's see if there is any interest. The package is almost finished so it is a pity to leave it like this.
I think this would be the right way to implement the validation of the coords.
Internal consistency checks with the data_vars are not included here, I am not sure it makes sense. The coords in the data_vars data arrays should be a subset of these. However xarray probably checks this so I am not sure it is necessary.
This could go to a schema validation step (looking at the consistency of the schema with itself, not with a datarray).