Skip to content

Commit

Permalink
[UIKit] Fixes UIGestureRecognizer default introduced in iOS 13.4 (#8264)
Browse files Browse the repository at this point in the history
Fixes xamarin/Xamarin.Forms#10162
Fixes #8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.

Co-authored-by: Alex Soto <alex@alexsoto.me>
  • Loading branch information
monojenkins and dalexsoto committed Apr 1, 2020
1 parent 786bfc0 commit 04acaf6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/uikit.cs
Expand Up @@ -6113,7 +6113,7 @@ interface UIGestureRecognizerDelegate {
bool ShouldReceivePress (UIGestureRecognizer gestureRecognizer, UIPress press);

[TV (13,4), iOS (13,4)]
[Export ("gestureRecognizer:shouldReceiveEvent:"), DelegateName ("UIGesturesEvent"), DefaultValue (false)]
[Export ("gestureRecognizer:shouldReceiveEvent:"), DelegateName ("UIGesturesEvent"), DefaultValue (true)]
bool ShouldReceiveEvent (UIGestureRecognizer gestureRecognizer, UIEvent @event);
}

Expand Down

4 comments on commit 04acaf6

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 04acaf6 Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 184 tests passed.

Failed tests

  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1) -> xamarin/maccore#1488

Ok 🤥

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Device tests passed on iOS on Azure DevOps(iOS): Html Report

🎉 All 150 tests passed 🎉

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Experimental DDFun pipeline

🔥 Device tests completed (Failed) on iOS-DDFun on Azure DevOps(iOS-DDFun) 🔥

Test results

73 tests failed, 77 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - device/Debug: Crashed
  • framework-test/iOS Unified 64-bits - device/Debug: Crashed
  • interdependent-binding-projects/iOS Unified 64-bits - device/Debug: Crashed
  • dont link/iOS Unified 64-bits - device/Debug: Crashed
  • link all/iOS Unified 64-bits - device/Debug: Crashed (MT1025: Could not list the crash reports on the device XQAiPadMiniRetinab.)
  • link sdk/iOS Unified 64-bits - device/Debug: Crashed
  • mono-native-compat/iOS Unified 64-bits - device/Debug: Crashed
  • mono-native-unified/iOS Unified 64-bits - device/Debug: Crashed
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Debug: TimedOut (MT1025: Could not list the crash reports on the device XQAiPadMiniRetinab.)
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Debug: TimedOut
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Debug: Crashed
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Debug: Crashed (MT1025: Could not list the crash reports on the device XQAiPadMiniRetinab.)
  • [xUnit] Mono BCL tests group 5/iOS Unified 64-bits - device/Debug: Crashed
  • mscorlib Part 1/iOS Unified 64-bits - device/Debug: TimedOut
  • mscorlib Part 3/iOS Unified 64-bits - device/Debug: TimedOut
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - device/Debug: Crashed
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/Debug: TimedOut
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Release: Crashed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Release (all optimizations): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug: SGenConc: Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter -mscorlib): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Release (interpreter -mscorlib): Crashed
  • framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
  • interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
  • fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
  • dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
  • link all/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
  • link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • link sdk/iOS Unified 64-bits - device/Release: Crashed
  • mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
  • mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Release: TimedOut
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): TimedOut
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Release: Crashed
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Release: Crashed
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • [xUnit] Mono BCL tests group 5/iOS Unified 64-bits - device/Release: Crashed
  • [xUnit] Mono BCL tests group 5/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • mscorlib Part 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • mscorlib Part 1/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): TimedOut
  • mscorlib Part 1/iOS Unified 64-bits - device/Release: TimedOut
  • mscorlib Part 1/iOS Unified 64-bits - device/Debug: SGenConc: TimedOut
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • mscorlib Part 2/iOS Unified 64-bits - device/Debug: SGenConc: TimedOut
  • mscorlib Part 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • mscorlib Part 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • mscorlib Part 3/iOS Unified 64-bits - device/Release: TimedOut
  • mscorlib Part 3/iOS Unified 64-bits - device/Debug: SGenConc: TimedOut
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 64-bits - device/Release: Crashed
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): TimedOut
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥

Test results

# Test run in progress: Building: 1, Running: 1, RunQueued: 122, Succeeded: 19, Ignored: 1113, TimedOut: 7

Failed tests

  • monotouch-test/tvOS - device/Debug: TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug): TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • [NUnit] Mono BCL tests group 1/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): TimedOut
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: SDK framework (debug): TimedOut

Please sign in to comment.