[WPF] Use project style SDK; target netcoreapp3.0

[krdmllr]

This adds .netcoreapp3.0 besides the existing net 4.6.1 framework target for the WPF backend.

Description of Change

Add target framework .netcoreapp3.0.
Replaces the old Platform.WPF project file with an project sdk style one.
Update the OpenTK.GLControl package to 3.0.1.

Issues Resolved

fixes #5092

API Changes

None

Platforms Affected

WPF

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

1. Build the project
2. Test the library with WPF/.NET Core 3

• Create a WPF/.NET Core 3 app and reference the created dll's
• Add the logic to init XF and show a XF ContentPage
• Run the project -> The content page should appear

3. Test the library with WPF/.NET Framework

• Create a WPF/.NET Framework app and reference the created dll's
• Add the logic to init XF and show a XF ContentPage
• Run the project -> The content page should appear

PR Checklist

• Has automated tests
• Rebased on top of the target branch at time of PR
• Changes adhere to coding standard

[dnfclas]

All CLA requirements met.

[jfversluis]

Hmm build errors, but I'm guessing we need to update the tooling on our side @rmarinho ?

C:\Program Files\dotnet\sdk\2.2.105\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): Error NETSDK1013: The TargetFramework value 'tizen40' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
C:\Program Files\dotnet\sdk\2.2.105\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): Error NETSDK1013: The TargetFramework value 'tizen40' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
C:\Program Files\dotnet\sdk\2.2.105\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): Error NETSDK1013: The TargetFramework value 'tizen40' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
Xamarin.Forms.Platform.WPF\Xamarin.Forms.Platform.WPF.csproj(0,0): Error : C:\Program Files\dotnet\sdk\2.2.105\Sdks\Microsoft.NET.Sdk.WindowsDesktop\Sdk not found. Check that a recent enough .NET Core SDK is installed and/or increase the version specified in global.json.
Xamarin.Forms.Platform.WPF\Xamarin.Forms.Platform.WPF.csproj(0,0): Error MSB4236: The SDK 'Microsoft.NET.Sdk.WindowsDesktop' specified could not be found.
Xamarin.Forms.Platform.WPF\Xamarin.Forms.Platform.WPF.csproj(0,0): Error MSB4236: The SDK 'Microsoft.NET.Sdk.WindowsDesktop' specified could not be found.
Xamarin.Forms.Platform.WPF\Xamarin.Forms.Platform.WPF.csproj(0,0): Error MSB4236: The SDK 'Microsoft.NET.Sdk.WindowsDesktop' specified could not be found.
C:\Program Files\dotnet\sdk\2.2.105\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): Error NETSDK1013: The TargetFramework value 'tizen40' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
C:\Program Files\dotnet\sdk\2.2.105\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): Error NETSDK1013: The TargetFramework value 'tizen40' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly.
Process 'msbuild.exe' exited with code '1'.

[krdmllr]

C:\Program Files\dotnet\sdk\2.2.105

Looks like you are not building with .net core 3? I used the latest preview (7) and enabled preview support in VS 2019.

[rmarinho]

@krdmllr this would need to install net core 3.0 preview on the bits, not sure if you are familiar with AzurePipelines but basically we need in the windows bits to use the botnet installer task to install .net core 3, and then try the build, you can edit our yaml file to do that.

[krdmllr]

@rmarinho i'm familiar with azure pipelines :)
In this yaml: https://github.com/xamarin/Xamarin.Forms/blob/master/build/steps/build-windows.yml ?

I would add the following task

- task: UseDotNet@2
  displayName: 'Install .NET Core 3 preview sdk'
  inputs:
    packageType: sdk
    version: 3.0.100-preview7-012821
    installationPath: $(Agent.ToolsDirectory)/dotnet

[rmarinho]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[krdmllr]

Can you see if the install .net core 3 task is successful?

We could create a global.json in the solution root directory during the build where we can set the .net core version https://docs.microsoft.com/de-de/dotnet/core/tools/global-json

dotnet new globaljson --sdk-version 3.0.100-preview7-012821

[krdmllr]

The build is currently failing because the installed VS/MSbuild version is too old for dotnetcore 3
.NET Core SDK requires at least version 16.0.0 of MSBuild. The current available version of MSBuild is 15.9.21.664.
Could you change the agent to a VS2019 one?

[krdmllr]

Besides the build pipelin issues I currently have the issue that the OpenTK lib does not target .net standard. Their update is on the way but I think it will take some time opentk/opentk#823

Since this only affects the OpenGLViewRenderer, I excluded the file and dependency when building for .net core 3 so this version currently does not support the OpenGLView. The .net461 version is unaffected.

[jfversluis]

I've been working with @krdmllr to get the build working. For now I have been manually triggering builds for the YAML file and we've made some progress. The one thing that seems to stop us now is that there is no Java SDK installed on the hosted Win2019/VS2019 agents.

[jfversluis]

Just revisiting this one. @rmarinho can we simply switch to VS2019 build agents? Is that planned already somewhere?

[rmarinho]

Last time i checked the vs2019 wasn't building our UWP projects out of the box

[krdmllr]

@rmarinho is there anything planned on your site to migrate to VS2019 build servers?

[jfversluis]

Tried to run the gallery app, but it becomes unresponsive immediately with a black screen

[jsuarezruiz]

Tested on two different machines (one of them is a Windows Virtual Machine) but, I see the same black screen on both cases.

We have to investigate what happens here, test with different .NET Core versions, etc.

[trturino]

The pages Gallery project is showing a black screen even if you build using .NET Framework

[trturino]

I just got the master branch and reapplied all changes that this branch has and the Gallery project start working again. At least on .NET Framework.
Maybe a rebase solve the problem.

I was running some additional tests, and have you realized that OpenTK is built only for .NET Framework? An 4.0 version is being developed with support of .Net Standard/Core.
But so far there is no OpenTK.GLControl for .NET Core / Standard

[krdmllr]

Finally fixed it, the generics.xaml wasnt loading because this got kicked out while merging [assembly: ThemeInfo(ResourceDictionaryLocation.None, ResourceDictionaryLocation.SourceAssembly)]
@PureWeen can you verify that everything works now :)? Thanks everyone for testing!

@trturino the OpenGL was discussed above (feb 22)

[VladislavAntonyuk]

What about other projects? Maps, Control Gallery? they should also be update to restore with netcoreapp

[rmarinho]

@VladislavAntonyuk PR's are welcome :) Some stuff like iOS and Android don't support sdk style projects right now irc.

[maxim-saplin]

I have build errors with blank WPF Core app and 4.8.0.780-nightly XF build. Should I add Xamarin.Forms package reference to the project and right away there're errors:

1>App.xaml : error : Value cannot be null.
1>App.xaml : error : Parameter name: key
1>MainWindow.xaml : error : Value cannot be null.
1>MainWindow.xaml : error : Parameter name: key

[VladislavAntonyuk]

@maxim-saplin , it is my favorite issue) Add <EmbeddedResource Remove="**\*.xaml" /> in your csproj

[maxim-saplin]

@VladislavAntonyuk that worked, thanks!

[MagicAndre1981]

@krdmllr

can you check this issue, please? During your csproj style change the application info data are lost, now version is 0.0.0.0