[Shell] The glorious Shell #4522

StephaneDelcroix · 2018-11-23T10:43:13Z

the glorious shell, as-is, behind a feature flag. some parts still need love/fixes

fixes #2415

Breaking Changes

[Android] ScrollViewRenderer now inherits from NestedScrollView

Xamarin.Forms.ControlGallery.Android/FormsAppCompatActivity.cs

rmarinho · 2018-11-27T19:32:48Z

We need to try to figure why so many UITests are failing

rmarinho

Failing uitests and I can replicate locally, looking at the Android ones first.

Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj

Xamarin.Forms.Platform.Android/VisualElementRenderer.cs

Xamarin.Forms.Core/DataTemplate.cs

Xamarin.Forms.Core/DependencyService.cs

fixed

Xamarin.Forms.Core/IDataTemplateController.cs

fixed

… was disposed

Xamarin.Forms.Platform.iOS/Xamarin.Forms.Platform.iOS.csproj

weitzhandler · 2018-11-30T11:47:04Z

Thanks for the great work.
Now the only thing Xamarin.Forms lacks is be compliant to UWP or WPF syntax.

fixes #5161

* Add null checks on new code paths added in #4522 fixes #5161 * Fix cast... Fixes #5247

samhouts added this to In Review in v3.6.0 Nov 23, 2018

StephaneDelcroix force-pushed the shell-master branch 4 times, most recently from 0940b85 to f32263b Compare November 26, 2018 19:17

samhouts previously requested changes Nov 26, 2018

View reviewed changes

Xamarin.Forms.ControlGallery.Android/FormsAppCompatActivity.cs Outdated Show resolved Hide resolved

samhouts moved this from In Review to In Progress in v3.6.0 Nov 26, 2018

samhouts added this to In progress in Sprint 145 Nov 26, 2018

samhouts added t/enhancement ➕ a/shell 🐚 e/10:clock10: 10 labels Nov 27, 2018

rmarinho suggested changes Nov 28, 2018

View reviewed changes

rmarinho reviewed Nov 28, 2018

View reviewed changes

Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj Show resolved Hide resolved

Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj Show resolved Hide resolved

rmarinho reviewed Nov 28, 2018

View reviewed changes

Xamarin.Forms.Platform.Android/VisualElementRenderer.cs Show resolved Hide resolved

PureWeen previously requested changes Nov 28, 2018

View reviewed changes

Xamarin.Forms.Core/DataTemplate.cs Show resolved Hide resolved

Xamarin.Forms.Core/DependencyService.cs Show resolved Hide resolved

StephaneDelcroix commented Nov 29, 2018

View reviewed changes

Xamarin.Forms.Core/IDataTemplateController.cs Show resolved Hide resolved

StephaneDelcroix force-pushed the shell-master branch 2 times, most recently from e3333bd to 6bb935e Compare November 29, 2018 12:23

StephaneDelcroix force-pushed the shell-master branch from 6bb935e to 22a43c3 Compare November 29, 2018 13:57

StephaneDelcroix and others added 8 commits November 29, 2018 16:09

[Shell] The glorious Shell

92bd2d9

set the flag for the test

7e11c46

remove the FastRenderer flag

20309be

[Android] If we were disposed earlier Element can be null and Control…

f9c86f2

… was disposed

[Controls] Seems part of #2520 was solved so we don't need this

6fb928a

[iOS] Fix NRE on the ScrollviewTracker

6a21b9a

add missing constructor for RenderWith

65c02c9

[Core] propagate visual/flow through shell

92b5be2

[iOS,Droid,Core] Code formatting

4123837

rmarinho reviewed Nov 29, 2018

View reviewed changes

Xamarin.Forms.Platform.iOS/Xamarin.Forms.Platform.iOS.csproj Show resolved Hide resolved

[iOS,Core] Last minute style refactoring

93c5d3d

samhouts approved these changes Nov 29, 2018

View reviewed changes

samhouts requested review from PureWeen, hartez, rmarinho and kingces95 November 30, 2018 00:12

PureWeen approved these changes Nov 30, 2018

View reviewed changes

samhouts merged commit 78385f9 into master Nov 30, 2018

v3.6.0 automation moved this from In Progress to Done Nov 30, 2018

Sprint 145 automation moved this from In progress to Done Nov 30, 2018

samhouts deleted the shell-master branch November 30, 2018 04:23

samhouts added this to the 4.0.0 milestone Dec 4, 2018

samhouts removed this from Done in v3.6.0 Jan 3, 2019

samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

samhouts added this to Done in v3.5.0 Jan 11, 2019

samhouts added this to Done in Sprint 147 Jan 11, 2019

samhouts added this to Done in Sprint 148 Jan 22, 2019

samhouts added the breaking Changes behavior or appearance label Feb 26, 2019

samhouts added a commit that referenced this pull request Feb 26, 2019

Add null checks on new code paths added in #4522

32bad6e

fixes #5161

This was referenced Feb 26, 2019

NullReferenceException in ScrollViewRenderer XF 3.5 #5161

Closed

[iOS, Android] Prevent NREs in ScrollViews #5383

Merged

samhouts added the API-change Heads-up to reviewers that this PR may contain an API change label Feb 26, 2019

samhouts added a commit that referenced this pull request Feb 28, 2019

[iOS, Android] Prevent NREs in ScrollViews (#5383)

0b7965f

* Add null checks on new code paths added in #4522 fixes #5161 * Fix cast... Fixes #5247

paymicro mentioned this pull request Mar 1, 2019

[Android] fixes ListView pull-to-refresh gesture in non-data areas #5417

Merged

3 tasks

King-Xero mentioned this pull request Jul 12, 2019

ListView in Xamarin Forms 4 With Shell in Android not Scrolling #6381

Closed

DineshBabuYadav mentioned this pull request Sep 18, 2019

[Bug] ScrollBar is not visible from Xamarin Forms v3.5.0.129452 in Android platform #7574

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shell] The glorious Shell #4522

[Shell] The glorious Shell #4522

StephaneDelcroix commented Nov 23, 2018 •

edited by samhouts

rmarinho commented Nov 27, 2018

rmarinho left a comment

weitzhandler commented Nov 30, 2018

[Shell] The glorious Shell #4522

[Shell] The glorious Shell #4522

Conversation

StephaneDelcroix commented Nov 23, 2018 • edited by samhouts

Breaking Changes

rmarinho commented Nov 27, 2018

rmarinho left a comment

Choose a reason for hiding this comment

weitzhandler commented Nov 30, 2018

StephaneDelcroix commented Nov 23, 2018 •

edited by samhouts