[Android] Changes in the logic to detect Device.Idiom

[jsuarezruiz]

Description of Change

Changed checking the UiMode enum using HasFlag to use ==. Based on this changes xamarin/Essentials@b937b12 from Xamarin Essentials.

Issues Resolved

• fixes [Bug] Xamarin.Forms.Device.Idiom return Desktop instead of Phone while Xamarin.Essentials.DeviceInfo.Idiom return idiom correct #11166
• fixes Device.Idiom for Android misleading in XF 4.7.0.968 #11177

API Changes

None

Platforms Affected

• Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[jsuarezruiz]

Retarget to 4.5.0.

[PureWeen]

Both API 19 tests have the same failures

[jsuarezruiz]

@PureWeen Yes, are failing the tests Issue2948 and Issue2951 although Device.Idiom is not used in these cases. Will take a look.

[PawKanarek]

Maybe test didn't succeed, because of you need to accept some new agreements?
@samhouts wrote:

For example, I just pinged a contributor yesterday about a test that I thought was legitimately failing, only to realize that it was actually failing because Chrome was asking us to accept the new terms of service. 🤦
dotnet/maui#109 (comment)

[rmarinho]

Going to rebase and run tests again .

Tests that were failoing were 2951 and 2948

[samhouts]

Same tests are failing. @jsuarezruiz Can you investigate, please? Thanks!

[PawKanarek]

Maybe i could potentially help with fix, but i have problems with identifying failing test, as im not familiar with azure pipeline...
Here i can see Message:

"2020-09-10T15:18:47.5457580Z ##[error]There are one or more test failures detected in result files. Detailed summary of published test results can be viewed in the Tests tab."

But the Tests tab is empty :(

[jsuarezruiz]

Updated the changes passing the failing UITests locally.

Waiting for the Build results!

[PureWeen]

I'm testing with the following code

			SetMainPage(new ContentPage()
			{
				Content = new StackLayout()
				{
					Children =
					{
						new Label()
						{
							Text = Device.Idiom.ToString()
						}
					}
				}
			});

And it's giving me back Unsupported. I'm testing on an API 23 emulator

if I roll back the changes here for Forms.cs then it gives me "Phone"

[jsuarezruiz]

@PureWeen Updated fixing that issue. Could you try/review it again please?

[rmarinho]

Ok tested with @PureWeen example, can get Phone and Tablet ok , in api 23/ api 29 , api 30