This repository has been archived by the owner on May 1, 2024. It is now read-only.
Only change out colors if they have actually changed #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
a/shell 🐚
blocker
PureWeen
commented
Apr 1, 2020
| using (var colorDrawable = new ColorDrawable(background.ToAndroid(ShellRenderer.DefaultBackgroundColor))) | ||
| toolbar.SetBackground(colorDrawable); | ||
| toolbarTracker.TintColor = foreground.IsDefault ? ShellRenderer.DefaultForegroundColor : foreground; | ||
| if (_titleTextColor != titleArgb) |
There was a problem hiding this comment.
Setting these values was causing a slight flickering of the hamburger icon when you popped a page
ahmedalejo
reviewed
May 3, 2020
| decorView.SetBackground(split); | ||
| if (!(decorView.Background is SplitDrawable splitDrawable) || | ||
| splitDrawable.Color != color || splitDrawable.TopSize != statusBarHeight || splitDrawable.BottomSize != navigationBarHeight) | ||
| { |
There was a problem hiding this comment.
Large conditions should be moved to a method to express the intent of what it´s trying to detect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist