New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some build issues #454
Conversation
It still does not work on Mac, but work on Windows (WarningsAsErrors) - found out this week after build started mysteriously failing on Windows CI. Not sure what was changed. |
I don't have access to your Azure Pipelines but it seems macOS and Windows environments may have different Java.Interop versions. I started having problems with Kotlin interfaces nested in private/internal classes after I upgraded to VS 16.9 (i.e. Xamarin.Android 11.2) on Windows. I'm not sure but some of these changes may be related: https://github.com/xamarin/java.interop/commits/main/src/Xamarin.Android.Tools.Bytecode/Kotlin/KotlinFixups.cs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert to latest 29.x.y build tools instead of 30.x.y, please?
The builds are failing
"/Users/runner/work/1/s/generated/GooglePlayServices.sln" (Build target) (1:2) ->
"/Users/runner/work/1/s/generated/com.google.mlkit.vision-internal-vkp/com.google.mlkit.vision-internal-vkp.csproj" (default target) (140:10) ->
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Legacy.targets(176,5): error XA0032: Java SDK 11.0 or above is required when using Android SDK Build-Tools 30.0.2. [/Users/runner/work/1/s/generated/com.google.mlkit.vision-internal-vkp/com.google.mlkit.vision-internal-vkp.csproj]
Yes, but that means you're using Xamarin.Android 11.1 or older. I guess my assumption about different Java.Interop versions on macOS and Windows is correct) |
…arin.Android version
I've created xamarin/java.interop#826. |
This PR is likely outdated and no longer relevant. |
This PR is part 1 of #437. It fixes some build issues related to main source directory.
build.cake changes
Cake.Core
is no longer appears in the build log.java
executable in thePATH
directly.JAVA_HOME/bin/java
may be used to generate javadocs now.nuget
executable in thePATH
nor installNuGet.Versioning
addin.MSBuild
is always used to restore projects now.MSBuild
is always uses specifiedMAX_CPU_COUNT
now.Related changes
Firebase-Iid.csproj
. I deleted it.GooglePlayServicesTargets.cshtml
had unnecessary duplicated tags.<NoWarn>
tags were filled incorrectly inGooglePlayServicesProject.cshtml
(I also addedBG8A01
in addition toBG8A00
andBG8A04
). Some of them didn't work earlier - so I addedTODO
s to review them as they may suppress potentially important warnings now.