Fix the incompatibility issue between Analytics and Messaging

[Iguins]

Google Play Services Version (eg: 8.4.0):

V9.0

Does this change any of the generated binding API's?

Yes

Describe your contribution

• Fix the incompatibility Issue between Analytics and Messaging by upgrading the proper dependencies.
  FirebaseAnalytics & FirebaseMessaging, version mismatch on gms.measurement.base #280

• "Seal" the sub-dependencies with seams to do not evolve anymore according to maven last update. This will help the Android-Binderator to complete his Dependencies check

[mattleibow]

Error from CI:

...
2020-04-07T03:16:09.0434840Z ========================================
2020-04-07T03:16:09.0435200Z samples
2020-04-07T03:16:09.0435570Z ========================================
...
2020-04-07T03:16:09.0501560Z Errors in /Users/runner/runners/2.165.2/work/1/s/samples/all/FbAll/FbBuildAll.csproj
2020-04-07T03:16:09.0502380Z     NU1107: Version conflict detected for Xamarin.Android.Support.Compat. Install/reference Xamarin.Android.Support.Compat 28.0.0.3 directly to project FbBuildAll to resolve this issue.
2020-04-07T03:16:09.0504120Z      FbBuildAll -> Xamarin.Firebase.Ads 71.1601.0 -> Xamarin.GooglePlayServices.Ads 71.1720.1 -> Xamarin.Android.Support.CustomTabs 28.0.0.3 -> Xamarin.Android.Support.Compat (= 28.0.0.3)
2020-04-07T03:16:09.0505640Z      FbBuildAll -> Xamarin.Firebase.Abt 71.1601.0 -> Xamarin.GooglePlayServices.Basement 71.1620.0 -> Xamarin.Android.Support.v4 28.0.0.1 -> Xamarin.Android.Support.Compat (= 28.0.0.1).
2020-04-07T03:16:09.0506340Z 
2020-04-07T03:16:09.0506800Z Errors in /Users/runner/runners/2.165.2/work/1/s/samples/all/GpsBuildAll/GpsBuildAll.csproj
2020-04-07T03:16:09.0507650Z     NU1107: Version conflict detected for Xamarin.Android.Support.Compat. Install/reference Xamarin.Android.Support.Compat 28.0.0.3 directly to project GpsBuildAll to resolve this issue.
2020-04-07T03:16:09.0509390Z      GpsBuildAll -> Xamarin.GooglePlayServices.Cast.Framework 71.1602.0 -> Xamarin.Android.Support.v7.MediaRouter 28.0.0.3 -> Xamarin.Android.Support.Media.Compat 28.0.0.3 -> Xamarin.Android.Support.Compat (= 28.0.0.3)
2020-04-07T03:16:09.0511280Z      GpsBuildAll -> Xamarin.GooglePlayServices.Basement 71.1620.0 -> Xamarin.Android.Support.v4 28.0.0.1 -> Xamarin.Android.Support.Compat (= 28.0.0.1).
2020-04-07T03:16:09.0511910Z 
...

Basically, somewhere there is a dependency on a support library 28.0.0.1 and 28.0.0.3. I think Xamarin.GooglePlayServices.Basement is referencing an old versions somehow...

@moljac might know offhand why the versions are not matching in this build...

[moljac]

@GuillaumeSE @mattleibow

During repo consolidation attempts I have set (or tried to set) all dependencies in config.json to 28.0.0.3. Why 28.0.0.1 appears I have no idea.

https://github.com/xamarin/GooglePlayServicesComponents/blob/master/config.json#L693-L732

Smells like some transitive dependency pulls 28.0.0.1 version[s]. Not sure. Wild guess.

[moljac]

due to the fact that dotnet does not have reinstall concept. I use this trick for installation/reinstallation:

dotnet tool uninstall --global Cake.Tool
dotnet tool install --global Cake.Tool

This way users are safe with the newest versions of the tools used to build the repo.

Othrewise approved.

[Iguins]

Pushed a new commit to fix Xamarin.GooglePlayServices.Ads

[moljac]

This is Firebase package, so we must bind it. It should be

"dependencyOnly" : false

[moljac]

This is Firebase package, so we must bind it. It should be

"dependencyOnly" : false

Meaning of

"dependencyOnly" : true 

is that it is not bound in. this repo, but there is dependency nuget. Dependency nuget could have jar/aar as payload (reference jar) which is not bound, but we don't do that. You will see all of "dependencyOnly" : true are external packages (Android.Support and other mostly from XamarinComponents repo, TensorFlow, etc...)

[moljac]

I understand it is Impl, so maybe not relevant for bindings, but our internal convention was to bind those too.

[Iguins]

Yes the only issue what that the binderator was complaining for a superior version But no new version have been Feb, 2019.
What should be the good approach for that kind of situation?

[moljac]

binderator was complaining for a superior version

This usually indicates something. OK. I have forked and am building. Will raise you PR (I hope)

[moljac]

This is crazy:

2020-04-07T03:16:09.0505640Z      FbBuildAll -> Xamarin.Firebase.Abt 71.1601.0 -> Xamarin.GooglePlayServices.Basement 71.1620.0 -> Xamarin.Android.Support.v4 28.0.0.1 -> Xamarin.Android.Support.Compat (= 28.0.0.1).

so:

Xamarin.GooglePlayServices.Basement 71.1620.0 -> Xamarin.Android.Support.v4 28.0.0.1 

and nuspec looks like this:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
  <metadata>
    <id>Xamarin.GooglePlayServices.Basement</id>
    <version>71.1620.0</version>
    <title>Xamarin.Android Bindings for Google Play Services -  Basement</title>
    <authors>Microsoft</authors>
    <owners>Microsoft</owners>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <licenseUrl>https://go.microsoft.com/fwlink/?linkid=865373</licenseUrl>
    <projectUrl>https://go.microsoft.com/fwlink/?linkid=865435</projectUrl>
    <iconUrl>https://raw.githubusercontent.com/xamarin/GooglePlayServicesComponents/master/icons/play-services-basement_128x128.png</iconUrl>
    <description>Xamarin.Android Bindings for Google Play Services - Basement 71.1620.0 

         - do not install directly</description>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <tags>Xamarin.Android Bindings for Google Play Services</tags>
    <dependencies>
      <group targetFramework="MonoAndroid9.0">
        <dependency id="Xamarin.Android.Support.v4" version="28.0.0.3" include="All" />
        <dependency id="Xamarin.Build.Download" version="0.10.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>
    <frameworkAssemblies>
      <frameworkAssembly assemblyName="Java.Interop" targetFramework="MonoAndroid9.0" />
    </frameworkAssemblies>
  </metadata>
</package>

Where does 28.0.0.1 come from?

[moljac]

@GuillaumeSE
When I build your fork I do get:

/Users/Shared/Projects/d/X/GPS-FB-gse/source/com.google.firebase/firebase-common/additions/TaskExtensions.cs(9,24): error CS0234: The type or namespace name 'Auth' does not exist in the namespace 'Firebase' (are you missing an assembly reference?) [/Users/Shared/Projects/d/X/GPS-FB-gse/generated/com.google.firebase.firebase-common/com.google.firebase.firebase-common.csproj]
    386794 Warning(s)
    1 Error(s)

I will check it and fix it with other stuff.

[Iguins]

@GuillaumeSE
When I build your fork I do get:

/Users/Shared/Projects/d/X/GPS-FB-gse/source/com.google.firebase/firebase-common/additions/TaskExtensions.cs(9,24): error CS0234: The type or namespace name 'Auth' does not exist in the namespace 'Firebase' (are you missing an assembly reference?) [/Users/Shared/Projects/d/X/GPS-FB-gse/generated/com.google.firebase.firebase-common/com.google.firebase.firebase-common.csproj]
    386794 Warning(s)
    1 Error(s)

I will check it and fix it with other stuff.

Thanks! I'm investigating on my side with part I did wrong!.
But At least now seams the dependencies mismatch seams like solved

[moljac]

@GuillaumeSE

Sorry for delay, but I have to make master green with new tooling. As soon as I finish that I'll check this PR.

I hope this is OK with you.

[epsmae]

@moljac Is there any update for this? Can you give a rough estimation when you expect to have this fixed?

[jpobst]

These versions predate AndroidX, so I'm guessing this is no longer relevant.