Rendering-related fixes, clean-up and DEBUG_LINES support #412
Conversation
|
TBH I was also going to open a PR on this issue Will link my branch anyway, just in case it is useful as a reference: https://github.com/thr3343/VulkanMod/tree/DrawMode |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
otherwise it draws some faint lines with a tiny bit of space in the middle
| @@ -161,7 +156,7 @@ private long createGraphicsPipeline(PipelineState state) { | |||
|
|
|||
| VkPipelineDynamicStateCreateInfo dynamicStates = VkPipelineDynamicStateCreateInfo.calloc(stack); | |||
| dynamicStates.sType(VK_STRUCTURE_TYPE_PIPELINE_DYNAMIC_STATE_CREATE_INFO); | |||
| dynamicStates.pDynamicStates(stack.ints(VK_DYNAMIC_STATE_DEPTH_BIAS, VK_DYNAMIC_STATE_VIEWPORT, VK_DYNAMIC_STATE_SCISSOR)); | |||
| dynamicStates.pDynamicStates(stack.ints(VK_DYNAMIC_STATE_DEPTH_BIAS, VK_DYNAMIC_STATE_VIEWPORT, VK_DYNAMIC_STATE_SCISSOR, VK_DYNAMIC_STATE_LINE_WIDTH)); | |||
There was a problem hiding this comment.
I suppose VK_DYNAMIC_STATE_LINE_WIDTH should only be added when using VK_PRIMITIVE_TOPOLOGY_LINE_*
There was a problem hiding this comment.
According to the docs, the only restriction with the wide line feature not being supported is that the line width cannot be anything other than 1.0.
There was a problem hiding this comment.
(So I did it for simplicity)
|
I wanted to thank you for your work, I'm interested in merging this PR as it resolves a compatibility issue I haven't got around to fix yet. |
VisualEhrmanntraut
changed the title
|
LINES mode is still a bit fishy so don't merge it yet until we figure it out :-) |
That's OK, just closed my review as it was outdated For LINES you can try quadsIndexBuffer instead of linesIndexBuffer, but oytl tested two mods with that thus far, so haven't tested that very thoroughly |
|
@thr3343 using that only helps with the F3 cursor for me, MiniHUD still has some quirks |
# Conflicts: # src/main/java/net/vulkanmod/vulkan/Drawer.java # src/main/java/net/vulkanmod/vulkan/memory/AutoIndexBuffer.java
This fixes mods the likes of Ad Astra amongst other problems.