Addign new feature to specify minimal required score for CLI print #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t out to terminal window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced one new feature, which is allowing the user to specify the minimal score a CT should reach before printing it out into CLI window. Should help with displaying only really high fidelity results or whatever the user is interested in.
Additionally, I did some code quality changes which I believe make more sense now. For instance, I removed the option for 'updating' suspicious YAML with external YAML, if the user DID NOT SPECIFY that they want to override the original yaml.
My understanding is that if user specifies to override the original yaml, it should actually override it and not update it. We can add a separate feature to update the existing YAML with new keywords or tlds.