Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed trying to open deleted projects on start #63

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

hateofhades
Copy link
Contributor

Description of the Change

When trying to load the previous project I've added a check to verify if the project folder exists, and if not will display the Project Library from where the user can create a new project or select another.

Benefits

No longer displays an error when it tries to open a deleted project on start.

Possible Drawbacks

None.

Applicable Issues

#59

Format

[x] ran npm run electron-format
[x] ran npm run browser-format

Author

Signed-off-by: Șerban Andrei usadekall@gmail.com

@alexandruradovici
Copy link
Collaborator

This is great, just a quick comment. When Wyliodrin STUDIO is started for the first time, it display a welcome dialog. Is this still showing up? To test it, simply clean the .wylidorinstudio folder from your user folder.

source/plugins/projects/projects/index.js Outdated Show resolved Hide resolved
source/plugins/projects/projects/index.js Outdated Show resolved Hide resolved
@hateofhades
Copy link
Contributor Author

This is great, just a quick comment. When Wyliodrin STUDIO is started for the first time, it display a welcome dialog. Is this still showing up? To test it, simply clean the .wylidorinstudio folder from your user folder.

Yes, it still does.

@alexandruradovici
Copy link
Collaborator

Please take a look at the requested changes

Co-authored-by: Alexandru Radovici <msg4alex@gmail.com>
@hateofhades
Copy link
Contributor Author

Please take a look at the requested changes

Neither project nor file is ever {}, but while testing to see if they can be I've found out that closing and opening Wyliodrin Studio for the first time without creating a project, opens the program on a blank page.

@alexandruradovici
Copy link
Collaborator

Please take a look at the requested changes

Neither project nor file is ever {}, but while testing to see if they can be I've found out that closing and opening Wyliodrin Studio for the first time without creating a project, opens the program on a blank page.

That is normal, you should have a Create New Application button displayed. The two variables should be null in that case. Can you please test and see if this is the case before we merge this?

@hateofhades
Copy link
Contributor Author

Please take a look at the requested changes

Neither project nor file is ever {}, but while testing to see if they can be I've found out that closing and opening Wyliodrin Studio for the first time without creating a project, opens the program on a blank page.

That is normal, you should have a Create New Application button displayed. The two variables should be null in that case. Can you please test and see if this is the case before we merge this?

When both variables are null it doesn't display the Create New Application button. But we could check if it isn't the first time running and both project and file are null to display it.

@alexandruradovici alexandruradovici merged commit 895ba05 into wyliodrinstudio:master Apr 26, 2021
@hateofhades hateofhades deleted the fixing59 branch April 29, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants