-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Running Code on Raspberry Pi Simulator With LCD #62
Conversation
Did you test all the examples for the LCD simulator? |
I got excited on testing it with custom circuits, but it seems not to work with the button examples. I'll investigate the problem. |
Do you mean custom LCD circuits? |
Yes, after it worked with the example LCD circuit, I created one in Fritzing to understand the simulator's functionality better. |
What you are sying is that it does not work for the examples that have an LCD and a button or just examples that have just a button? |
It does not work with the examples that have both LCD and buttons. I will also test it with LCD and LED, because I think the problem has something to do with mixing LCD with other components. |
The error came from an array initialization in the wrong spot. Because of it, the |
Description of the Change
Fixed problems related to LCD simulation for the Raspberry Pi. Removed undefined references and checks
Benefits
Now the Raspberry Pi simulator can run LCD projects
Possible Drawbacks
There was a check for an active property, which LCD components do not have. If it wasn't there by mistake, I couldn't find a replacement for its logic, and that could cause errors.
Applicable Issues
#56
Format
[ x ] ran
npm run electron-format
[ x ] ran
npm run browser-format
Author
Signed-off-by: Silvășan Bogdan bogdan.silve@gmail.com