Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WebP image file format via libwebp. #24479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoehermann
Copy link

@hoehermann hoehermann commented Apr 16, 2024

This is a pull request for #23489. Please refer to the conceptual discussion there. Discuss suggestions regarding this particular pull-request here.

Update: I consider this ready for merging.

@hoehermann hoehermann marked this pull request as draft April 16, 2024 17:58
@hoehermann hoehermann force-pushed the libwebp branch 3 times, most recently from 347123b to b35e205 Compare April 19, 2024 10:18
@hoehermann hoehermann marked this pull request as ready for review April 19, 2024 14:36
@Randalphwa
Copy link
Contributor

Because this requires a library that is not built by wxWidgets itself, I'm assuming that anyone wanting to use this functionality will not be able to use any of the pre-built binaries? Or are you envisioning that all the pre-built binaries should have webp support turned on by default? If the pre-built binaries aren't going to have webp support, then it should be documented that the user must build wxWidgets from source to get this functionality.

I'm not familiar with the Chromium repository system, but I do note that the issue you refered to ( https://chromium-review.googlesource.com/c/webm/libwebp/+/4868215 ) states that the change was merged on 9/19/2023 -- so wouldn't the fix be in the current 1.4 release (released 4/12/2024)?

@hoehermann
Copy link
Author

I answered to Randalphwa's question at #23489 (comment) to keep the discussion in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants