Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wxSTC XYToPosition() / PositionToXY() at end position #23624

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix wxSTC XYToPosition() / PositionToXY() at end position #23624

wants to merge 3 commits into from

Conversation

swt2c
Copy link
Contributor

@swt2c swt2c commented Jun 9, 2023

No description provided.

swt2c and others added 2 commits June 8, 2023 23:00
@swt2c
Add tests for wxStyledTextCtrl PositionToXY() / XYToPosition()
f06adbd 
These were shamelessly copied from TestCtrlTestCase in
tests/controls/textctrltest.cpp.
@afalkenhahn @swt2c
Fix wxSTC XYToPosition() / PositionToXY() at end position
5d78522 
This was broken by 6e556d4.

Fixes wxWidgets#18430.
@swt2c swt2c mentioned this pull request Jun 9, 2023
Open
@swt2c swt2c changed the title Fix wxSTC wxSTC XYToPosition() / PositionToXY() at end position Fix wxSTC XYToPosition() / PositionToXY() at end position Jun 9, 2023
@vadz
Copy link
Contributor

vadz commented Jun 9, 2023

Thanks for the PR! Not really surprisingly, it does fail, but I guess the question is whether it fails "worse" with this change than without it. I'm also surprised it fails in one wxGTK3 build and not all of them.

@swt2c
Copy link
Contributor Author

swt2c commented Jun 13, 2023

I had forgotten to commit the changes to the include/wx/stc/stc.h file (not sure why that didn't get regenerated automatically?) which seems to have been the cause of some of the failures. Now, it's just down to a few MSW failures (but not all, of course!).

@vadz vadz added the work needed Too useful to close, but can't be applied in current state label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work needed Too useful to close, but can't be applied in current state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swt2c @vadz @afalkenhahn