Add support to python only pdfviewer for displaying pdf files where not all pages are the same size #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2023
|
See discussion and review of this PR in #2492 (comment) |
jmoraleda
force-pushed
the
variable-page-size-pdfviewer
branch
from
55020c3
to
7e0e98f
Compare
…not all pages have the same size
jmoraleda
force-pushed
the
variable-page-size-pdfviewer
branch
from
7e0e98f
to
87aae0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PDF viewer assumes all pages in the PDF document being displayed are of the same size. When this is not the case the PDF does not display correctly.
This PR refactors the viewer so that PDF documents containing pages of different sizes display correctly.
I have thoroughly tested this PR in GTK and MSW and have found it to produce the correct results and have performance comparable to the previous version including for larger documents.