Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AuiManager pane minimizing issue. #2447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tianzhuqiao
Copy link

Fixes #2361

@jmoraleda
Copy link
Contributor

jmoraleda commented Dec 4, 2023

@tianzhuqiao If you have a chance, could you please test if making the change in this image --removing three lines and making all platforms use wx.CallAfter-- also fixes your original issue, instead of reordering the lines?

image

I've been testing this change for a while before making a PR for it and I think it addresses multiple drawing and flickering issues and makes behavior across platforms more similar in some subtle ways. I don't have a Mac and I don't experience the issue you are reporting. But since this change addresses other reordering issues I wonder if the issue you report might also be addressed by it. Thank you.

@tianzhuqiao
Copy link
Author

@jmoraleda, thanks, just tested it on macOS, it shows the same issue with the change (always use wx.CallAfter)

@jmoraleda
Copy link
Contributor

@jmoraleda, thanks, just tested it on macOS, it shows the same issue with the change (always use wx.CallAfter)

Thank you for looking into it. Sorry I couldn't help.

@Metallicow
Copy link
Contributor

Kind of a touchy issue when you have to write something like... if __WXGTK__ in wx.PlatformInfo as I thought it might help years also and in some spots I wound back up at a conclusion as to WHY? would I do this if I had already commented out that line before on another linuxbox and just told it to wxCallAfter... Not sure but this may be what Robin was refering to as cruft when Phoenix was first RELz in the early versions. Might ask Robin... Is this logic really cruft?

In my newer WIPz "aui" rewrite, I have removed all offending platforms lines and started new. If it doesn't work, then I'll deal with specifics after its released if at all. ...Not monkeyjump all over the place into a million linux flavors. Maybe something such as the fabled focus event fix could screw something like this up also... idunno at this point.

... would If __GTK__("ubuntu 1947") type of code might work better..? We have absolutely no reference to any specific os system it seems at this point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wx.lib.agw.aui Minimize pane issue
3 participants