Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed when <library>true</library> specified in inclusions/inclusion,… #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed when <library>true</library> specified in inclusions/inclusion,… #80

wants to merge 2 commits into from

Conversation

lexchou
Copy link

@lexchou lexchou commented Apr 4, 2019

… the filter was ignored

lasselindqvist
lasselindqvist requested changes May 14, 2019
View reviewed changes
Copy link
Collaborator

@lasselindqvist lasselindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indendation is funny. It seems that you are using spaces instead of tabs.
Also, would it be better for the lines 457-466 be next to the line 481?

@lasselindqvist
Copy link
Collaborator

I resolved the conflicts for this. @lexchou can you confirm that they went as intended?

@lasselindqvist
Copy link
Collaborator

Also needs conflicts to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasselindqvist lasselindqvist lasselindqvist requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lexchou @lasselindqvist