Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Java 9 multi release jars #61 #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for Java 9 multi release jars #61 #76

wants to merge 2 commits into from

Conversation

liamsharp
Copy link

@liamsharp liamsharp commented Jul 20, 2018 •
edited by lasselindqvist

  • A property for library jar exclusions (libraryJarExclusion)

Fixes #61

@liamsharp
Add support for Java 9 multi release jars wvengen#61
10e1342 
- A property for library jar exclusions (libraryJarExclusion)
@liamsharp liamsharp mentioned this pull request Jul 20, 2018
Closed
@lasselindqvist lasselindqvist mentioned this pull request May 14, 2019
Closed
lasselindqvist
lasselindqvist reviewed Jun 17, 2019
View reviewed changes
src/main/java/com/github/wvengen/maven/proguard/ProGuardMojo.java
@@ -753,6 +749,19 @@ public void execute() throws MojoExecutionException, MojoFailureException {
}
}

private void addLibraryJar(ArrayList<String> args, ArrayList<File> libraryJars, File file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the method signature we could just use List instead of ArrayList

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private void addLibraryJar(ArrayList<String> args, ArrayList<File> libraryJars, File file)
private void addLibraryJar(List<String> args, List<File> libraryJars, File file)

lasselindqvist
lasselindqvist reviewed Jun 17, 2019
View reviewed changes
src/main/java/com/github/wvengen/maven/proguard/ProGuardMojo.java
args.add("-libraryjars");
args.add(fileToString(file));
if (libraryJarExclusion != null) {
args.add(libraryJarExclusion);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly, this exclusion string should be added immediately after the filename without any spaces between them. This would seem to add it as a separate argument for the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasselindqvist lasselindqvist lasselindqvist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Java 9 multi release jars
2 participants
@liamsharp @lasselindqvist