Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WAR file processing #57

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

radomirml
Copy link

Submitting this PR as recently suggested by @cmorty .

I guess WAR specific instructions from the README.md should be moved to a more appropriate location before merging.

@Lonzak
Copy link

Lonzak commented Feb 13, 2018

I would be interested in this, too.
@wvengen can you accept this PR? What is the problem?

@wvengen
Copy link
Owner

wvengen commented Feb 14, 2018

Thanks for the changes. Ideally this would have been rebased, and not include the fork-specific README changes, to be a clean PR.
@cmorty do you think the code changes are fine?
I can try to find some time to pick the relevant changes and merge them.

@Lonzak
Copy link

Lonzak commented Feb 15, 2018

I can try to find some time to pick the relevant changes and merge them.

That would be highly appreciated. Thanks!

@lasselindqvist
Copy link
Collaborator

I would like to merge this, but this needs to be completely redone on top of the changed code. I cannot easily resolve the conflicts myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants