Added PowerShell Port to repository #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PowerShell Port to repository.
florian-lapp
reviewed
Mar 3, 2024
| #:getValues | ||
| function GetValues { | ||
| # for /f "tokens=4 delims=[] " %%a in ('ver') do set version=%%a | ||
| $Version = systeminfo | findstr /B /C:"OS Version" |
There was a problem hiding this comment.
The output of systeminfo is localized. The output of ver is not localized. Or have a look at some alternatives: https://ss64.com/ps/syntax-ver.html.
florian-lapp
reviewed
Mar 3, 2024
| $choices = '&Yes', '&No' | ||
|
|
||
| if(-not (Test-Path "$env:USERPROFILE\Desktop\Backup\Regedit\$currentDate\" -PathType Container)) { | ||
| mkdir "$env:USERPROFILE\Desktop\Backup\Regedit\$currentDate\" |
There was a problem hiding this comment.
On my system this invocation of mkdir failed, because it does not create parent directories. This also applies to the batch script wureset.bat. PowerShell has New-Item -Type Directory -Force ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent a little while re-writing this script to be PowerShell compatible. Still has some Batch code in the PS1 script, but it was avoided wherever possible (within reason). This is more future-proofing than it is any appreciable upgrade. Added code so the script can correctly identify Windows 11. Dropped support for older windows, as this is a PowerShell script and won't run on a windows without PowerShell. The Batch file is still present for compatibility.
Most notable change is the addition of a self-elevation function, which checks if the script is running with administrator privileges and triggers the windows UAC if necessary.
Also cleaned up some of the grammar. It wasn't bad, but it did bother me.