DBeditor v3 pull request #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keyboard will be closed on dialog dismiss
- Removed value TextView in dialog - Dialog Key font bold, centered and purple - EditText into a ScrollView to make scrolling faster
- Dialog EditText has the VALUE as text (so you can edit value without manual rewriting it) - Multiline EditText for strings (no numbers) - Dialog EditText and ScrollView both starts from bottom - Dialog EditText text centered for numbers and left aligned fr strings (just for design) - If edittext content is a string (not number), width is match parent, hint text is "Enter string" (just for design) - If edittext content is a number (integer or decimal), the width is wrap content (with android:minEms=3 ) and the hint text is "Value" (just for design)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daxgirl tells that you've some other modifications for DBeditor but you don't have committed them yet.
I you want you can merge my DBeditor v3 master into your master, so before adding your new features you will have also my features in your repo.
Regards.
lucadalba