Fix duplicate matches #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't bother with older versions.
|
Thanks for the PR, but removing Python 2 is a non-starter. I realize that Python 2 is EOL, but autojump is used in production at quite a few companies that are still running Python versions as old as 2.4. |
|
Dropping older Python versions was the way for me to get going quickly. I requested another pull #646 which keeps the versions unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing #348, this removes support for older Python
versions (i.e. other than 3.9) in testing rather rigorously, since I'm
not spending my time on old stuff.
Even though this tool doesn't seem to be maintained anymore, this will
enable the subscribers of #348 to cherry-pick the fix to their forks.