Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _base.html #125

Closed
wants to merge 1 commit into from
Closed

Update _base.html #125

wants to merge 1 commit into from

Conversation

duhanguler
Copy link
Contributor

@duhanguler duhanguler commented Mar 28, 2024

This pull request addresses a styling issue in the navbar menu. The items that should be on the right side of the menu were not rendering correctly due to the <ul> tag closing within the {% else %} block. Additionally, the styling for the form with the class form-dflex me-auto was adjusted to ensure proper alignment.

Changes:

Added </ul> to close the <ul> tag under the {% else %} block.
Adjusted the styling for the form with the class form-dflex me-auto for proper alignment.

Why This Change Was Made:
To ensure proper rendering of the navbar menu and form alignment, it was necessary to close the <ul> tag within the {% else %} block and adjust the form styling accordingly. These fixes ensure that menu items are displayed correctly and that the form aligns properly.

Technical Explanation:
Closing the <ul> tag within the {% else %} block ensures correct HTML structuring for the navbar menu, allowing items on both the right and left sides to render correctly. Additionally, adjusting the styling for the form with the class form-dflex me-auto ensures proper alignment according to the Bootstrap layout. These changes contribute to improved visual consistency and user experience.

This pull request addresses a styling issue in the navbar menu. The items that should be on the right side of the menu were not rendering correctly due to the <ul> tag closing within the {% else %} block. Additionally, the styling for the form with the class form-dflex me-auto was adjusted to ensure proper alignment.

Changes:

Added </ul> to close the <ul> tag under the {% else %} block.
Adjusted the styling for the form with the class form-dflex me-auto for proper alignment.
Why This Change Was Made:
To ensure proper rendering of the navbar menu and form alignment, it was necessary to close the <ul> tag within the {% else %} block and adjust the form styling accordingly. These fixes ensure that menu items are displayed correctly and that the form aligns properly.

Technical Explanation:
Closing the <ul> tag within the {% else %} block ensures correct HTML structuring for the navbar menu, allowing items on both the right and left sides to render correctly. Additionally, adjusting the styling for the form with the class form-dflex me-auto ensures proper alignment according to the Bootstrap layout. These changes contribute to improved visual consistency and user experience.
@wsvincent
Copy link
Owner

Thank you for your efforts here @duhanguler. I have made some updates to this file to make it more compatible spurred on by your PR. I appreciate it!

@wsvincent wsvincent closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants