-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Testing Framework #1951
Open
islas
wants to merge
156
commits into
wrf-model:develop
Choose a base branch
from
islas:test-workflow
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New Testing Framework #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… real underlying culprit
Add working em_ideal tests
Add chem tests to new testing framework
The regression test results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: testing, regression, test framework
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The current regression suite code is complex, requires maintenance of multiple alternate repositories, and takes involved effort to add a new test making community contribution limited at best. Likewise, the complexity of the system reduces the likelihood of independent local testing of changes, leading to a development cycle of one-off commits done to reinvoke testing to see if meaningful commits fix the issues.
Solution:
This new proposed regression suite addresses these shortcomings in a number of discrete ways:
LIST OF MODIFIED FILES:
A .ci/env/cheyenne.sh
A .ci/env/derecho.sh
A .ci/env/helpers.sh
A .ci/env/hostenv.sh
A .ci/env/wsl.sh
A .ci/missingTests.md
A .ci/tests/SCRIPTS
A .ci/tests/build.sh
A .ci/tests/runNamelists.sh
A .ci/wrf_arw_tests.json
A .ci/wrf_chem_tests.json
A .ci/wrf_em_ideal_tests.json
A .ci/wrf_em_real_tests.json
A .github/workflows/ci.yml
M .gitignore
M .gitmodules
M arch/postamble
M configure
M external/io_netcdf/diffwrf.F90
A hpc-workflows
M main/depend.common
TESTS CONDUCTED:
RELEASE NOTE:
Introduce a modularized testing framework that allows testing locally and natively on HPC systems that lives within the WRF repository