-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary EM_CORE checks #1756
base: develop
Are you sure you want to change the base?
Conversation
The Jenkins tests have passed (including all fixes up to now in release-v4.4.1 branch):
|
@weiwangncar |
I was using this PR to test a few things, including the data.h change. This PR does not need to be included in 4.4.1 release. I will change the marking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a pending comment. It is labeled as Do Not Merge, but I think it can be if this comment is answered. It is mostly just clean-up.
@@ -75,7 +75,7 @@ typedef struct node_struct { | |||
char pkg_4dscalars[NAMELEN_LONG] ; | |||
|
|||
/* fields used by Comm (halo, period, xpose) nodes */ | |||
char comm_define[2*8192] ; | |||
char comm_define[4*8192] ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can someone explain this, otherwise this commit looks safe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dudhia I created this PR to test the repository at the time. The line you pointed out is a fix we put in to correct moving nest compilation error which has been included in the repository (PR#1758 for 4.4.1). There are many clean-ups that can be done, so this is not complete at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest reverting this change, as it has nothing to do with EM_CORE
checks.
Remove a few unnecessary EM_CORE checks
TYPE: no impact, code clean up
KEYWORDS: EM_CORE, clean up, check_a_mundo
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Some EM_CORE checks in the routine are no longer needed.
Solution:
They are removed.
LIST OF MODIFIED FILES:
M share/module_check_a_mundo.F
TESTS CONDUCTED:
RELEASE NOTE: