Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRF-TEB integration #1064

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

WRF-TEB integration #1064

wants to merge 3 commits into from

Conversation

dmey
Copy link

@dmey dmey commented Jan 27, 2020

TYPE

New feature

KEYWORDS

urban, town energy balance, land surface, software development

SOURCE

Meyer, D., Schoetter, R., Riechert, M., Verrelle, A., Tewari, M., Dudhia, J., Masson, V., Reeuwijk, M., & Grimmond, S. (2020). WRF‐TEB: implementation and evaluation of the coupled Weather Research and Forecasting (WRF) and Town Energy Balance (TEB) model. Journal of Advances in Modeling Earth Systems. https://doi.org/10.1029/2019ms001961

DESCRIPTION OF CHANGES

WRF-TEB (Meyer et al., 2020a) couples the single layer Town Energy Balance (TEB) model (Masson, 2000, and subsequent papers) model, software (Meyer et al., 2020b), to the Weather Research and Forecasting (WRF; Skamarock et al., 2019).

This PR includes all the files modified in WRF as well as the wrapper for TEB phys/module_sf_teb.F used to integrate TEB model (https://github.com/teb-model/teb) as an external library into WRF.

The implementation here reflects what is in Meyer et al., 2020a with WRF-CMake (Riechert and Meyer, 2010). The entry point for TEB is phys/module_sf_teb.F which calls src/driver/modd_wrf_teb_driver.F90 from the TEB model repository https://github.com/teb-model/teb. Information on how to install and run WRF-TEB are included in external/teb/README.md.

References

Masson, V. (2000). A Physically-Based Scheme For The Urban Energy Budget In Atmospheric Models. Boundary-Layer Meteorology, 94(3), 357–397. https://doi.org/10.1023/a:1002463829265

Meyer, D., Schoetter, R., Riechert, M., Verrelle, A., Tewari, M., Dudhia, J., Masson, V., Reeuwijk, M., & Grimmond, S. (2020a). WRF‐TEB: implementation and evaluation of the coupled Weather Research and Forecasting (WRF) and Town Energy Balance (TEB) model. Journal of Advances in Modeling Earth Systems. https://doi.org/10.1029/2019ms001961

Meyer, D., Schoetter, R., Masson, V., & Grimmond, S. (2020b). Enhanced software and platform for the Town Energy Balance (TEB) model. Journal of Open Source Software, 5(50), 2008. https://doi.org/10.21105/joss.02008

Riechert, M., & Meyer, D. (2019). WRF-CMake: integrating CMake support into the Advanced Research WRF (ARW) modelling system. Journal of Open Source Software, 4(41), 1468. https://doi.org/10.21105/joss.01468

Skamarock, W. C., Klemp, J. B., Dudhia, J., Gill, D. O., Liu, Z., Berner, J., … Huang, X.-Y. (2019). A Description of the Advanced Research WRF Model Version 4. https://doi.org/10.5065/1DFH-6P97

LIST OF MODIFIED FILES:

M       Registry/Registry.EM_COMMON
M       Registry/registry.dimspec
M       arch/Config.pl
M       arch/postamble
M       dyn_em/module_first_rk_step_part1.F
M       dyn_em/module_initialize_real.F
M       dyn_em/start_em.F
A       external/teb/README.md
M       main/depend.common
M       phys/Makefile
M       phys/module_physics_init.F
M       phys/module_sf_noahdrv.F
A       phys/module_sf_psychrolib.F
A       phys/module_sf_teb.F
M       phys/module_sf_urban.F
M       phys/module_surface_driver.F
A       run/URBPARM_TEB.TBL
M       share/module_check_a_mundo.F

TESTS CONDUCTED

TODO -- @davegill I have already carried out tests and I will update this but please clarify if you want bit-for-bit identical output files in which case we would need remove the following from history/have them on only when TEB is enabled.

@dmey dmey requested review from a team as code owners January 27, 2020 15:14
@davegill
Copy link
Contributor

davegill commented Jan 27, 2020

@dmey @dudhia @weiwangncar @barlage
Since this is a new physics option, this code will need to go through the Physics Review Board.

Here is a link to the page describing the Physics Review Process:
https://www2.mmm.ucar.edu/wrf/users/physics_review.php

@dmey
Copy link
Author

dmey commented Jan 27, 2020

@dmey @dudhia @weiwangncar @barlage
Since this is a new physics option, this code will need to go through the Physics Review Board.
Here is a link to the page describing the Physics Review Process:
https://www2.mmm.ucar.edu/wrf/users/physics_review.php

@dudhia @davegill @weiwangncar @barlage should I go ahead and send a letter of intent (LOI) to the Physics Review Panel (PRP) (e-mail: wprp@ucar.edu)? It looks like the statements on the LOI are a subset of those in the paper already. Else we could simply share the the paper/summary of it as it includes more.

@davegill
Copy link
Contributor

@dudhia @barlage @weiwangncar
Folks,
It has been 5 months. Any movement from the physics review board?

@davegill
Copy link
Contributor

@dmey @dudhia @weiwangncar @barlage

This PR includes all the files modified in WRF as well as the wrapper for TEB phys/module_sf_teb.F used to integrate TEB model (https://github.com/teb-model/teb) as an external library into WRF.

What does "external library" mean? Is this a separately compiled set of files that produce a Unix library file? Is this just a way of referring to a traditional subroutine call?

@dudhia
Copy link
Collaborator

dudhia commented Jun 17, 2020 via email

@dmey
Copy link
Author

dmey commented Jun 18, 2020

What does "external library" mean? Is this a separately compiled set of files that produce a Unix library file? Is this just a way of referring to a traditional subroutine call?

@davegill a library dependency similarly to what is already done with other external libraries such as libnetcdf. TEB is therefore installed first on the system and then linked against if the user wishes to use the coupled WRF-TEB. I have detailed this more fully in section 4.1 in https://doi.org/10.1029/2019ms001961. Actual installation instructions on how to do this are in external/teb/README.md.

@dudhia
Copy link
Collaborator

dudhia commented Jun 18, 2020 via email

@dmey
Copy link
Author

dmey commented Jun 18, 2020

Yes, the build is certainly different, and we would like an explanation of why it can't be done similarly to the other physics in WRF, Jimy

Section 4 -- Software Implementation -- should explain.

@dudhia
Copy link
Collaborator

dudhia commented Jun 18, 2020 via email

@weiwangncar
Copy link
Collaborator

@dmey Do you have an interest to incorporate TEB urban model to NoahMP? I'm asking this since going forward most development on the land model will be on NoahMP.

@dmey
Copy link
Author

dmey commented Jun 19, 2020

@dmey Do you have an interest to incorporate TEB urban model to NoahMP? I'm asking this since going forward most development on the land model will be on NoahMP.

@weiwangncar I was not planning to do this. I am also not familiar with the NoahMP code but if you can spare some help, maybe this is something that we can plan for a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants