Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clearFiles project property #736

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add clearFiles project property #736

wants to merge 1 commit into from

Conversation

KangarooKoala
Copy link

Let me know if I missed something obvious, I hadn't looked much at the GradleRIO project before.

spacey-sooty
spacey-sooty reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@spacey-sooty spacey-sooty left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely be documented under gradlew tasks on frc-docs if its done like this.

I don't think this should be an artifact it feels better suited as another task that gets added onto the deploy task to me

@KangarooKoala
Copy link
Author

That would be a nice way to do it, but at first glance I didn't find an easy way to get a task that has access to the DeployContext, but if I have more time hopefully I'd find a cleaner way. (I also should double-check it works...)

@spacey-sooty
Copy link
Contributor

This would close wpilibsuite/deploy-utils#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KangarooKoala @spacey-sooty